Skip to content

Fix commented_by for any approver rule

Robert May requested to merge commented-by-4 into master

What does this MR do?

This fixes the new commented_by field for the "Any Approver" rule, which needed different logic to return the valid commenters.

image

Previous context: !39237 (merged)

Related #10294 (closed)

Closes #235884 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Robert May

Merge request reports