Replace deprecated-button - shared runner minutes
What does this MR do?
This MR updates the buttons in this file from <gl-deprecated-button> to <gl-button> in
ee/app/assets/javascripts/jobs/components/shared_runner_limit_block.vue.
Closes: #219784 (closed)
Screenshots
| Before | After |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.3
1 Message 
CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 39393 "Replace deprecated-button - shared runner minutes"If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 39393 "Replace deprecated-button - shared runner minutes"If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Robert Hunt ( @rob.hunt)Tim Zallmann ( @timzallmann)If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Edited by 🤖 GitLab Bot 🤖-
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits bbd825bd and 0019deb5
Entrypoint / Name Size before Size after Diff Diff in percent average 3.53 MB 3.53 MB - 0.0 % mainChunk 2.67 MB 2.67 MB - 0.0 %
Note: We do not have exact data for bbd825bd. So we have used data from: d877d995.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-reviewjob
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
assigned to @sselhorn
Resolved by Suzanne Selhorn@jareko Another broken pipeline for you, different than the last. Can you help? Thanks so much.
- Last reply by Suzanne Selhorn
assigned to @jareko
added 152 commits
-
8e476a4b...b2639156 - 151 commits from branch
master - 0019deb5 - Replace deprecated-button with button
-
8e476a4b...b2639156 - 151 commits from branch
unassigned @jareko
- Resolved by Andrew Fontaine
@justin_ho Can you review? This is part of an OKR where UX is updating buttons. Thanks!
- Last reply by Taurie Davis
assigned to @justin_ho and unassigned @sselhorn
mentioned in issue technical-writing#215
assigned to @sselhorn and unassigned @justin_ho
assigned to @afontaine
unassigned @jareko
assigned to @sselhorn
assigned to @samdbeckham and unassigned @sselhorn
unassigned @samdbeckham
mentioned in epic &4070 (closed)
-
Great stuff @sselhorn
-
@afontaine I saw you fix that broken pipeline. Thanks sooo much for that.
enabled an automatic merge when the pipeline for 6d72c1f2 succeeds
mentioned in commit e6e504ac
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added grouppurchase [DEPRECATED] sectionfulfillment labels and removed devopsgrowth label
This merge request has been deployed to the release.gitlab.net environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.
added published label