Skip to content

Fix typo for area chart embeds

What does this MR do?

We can embed metric charts in markdown for alerts from externally-managed prometheus instances. Unfortunately, there's a typo in the dashboard code which assigns a chart type which does not exist!

This fixes that typo! line-graph (bad!) -> area-chart (good!)

Embeds still have worked up until this point because line-graph isn't a valid option and the default chart is an area-chart. So we've just defaulted to the correct behavior instead of choosing it.

This came up in discussions for: #217769 (comment 394014737)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Sarah Yasonik

Merge request reports