Change sub-epics to child epics in errors and GraphQL schema
What does this MR do?
In the docs, we refer to sub-epics as "child epics", so change the error messages and API descriptions to match this.
Related issues
Close #235773 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.3
added GraphQL Technical Writing UI text devopsplan groupproduct planning twdoing labels
@rajatgitlab Would you mind reviewing this MR?
cc @kokeefe @uhlexsis This is me looking at epic-related error messages.
Edited by Marcin Sedlak-Jakubowskiassigned to @rajatgitlab and unassigned @msedlakjakubowski
assigned to @msedlakjakubowski and unassigned @rajatgitlab
@rajatgitlab Actually, let me add some things here
added documentation label
2 Messages This merge request adds or changes files that require a review from the Technical Writing team. CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 39351 "Change sub-epics to child epics in errors and GraphQL schema"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 39351 "Change sub-epics to child epics in errors and GraphQL schema"
If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message.
Documentation review
The following files require a review from a technical writer:
doc/api/graphql/reference/index.md
The review does not need to block merging this merge request. See the:
- Technical Writers assignments for the appropriate technical writer for this review.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Alex Ives ( @alexives
) (UTC-5, 7 hours behind@msedlakjakubowski
)Robert Speicher ( @rspeicher
) (UTC-5, 7 hours behind@msedlakjakubowski
)These files couldn't be categorised, so Danger was unable to suggest a reviewer. Please consider creating a merge request to add support for them.
doc/api/graphql/reference/gitlab_schema.graphql
doc/api/graphql/reference/gitlab_schema.json
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- 203b3e48 - Change to "non-confidential" in UI and spec files
added 2 commits
- Resolved by Achilleas Pipinellis
@rajatgitlab @alexives Could you review this please?
I fixed what pipelines I could, but I don't know how to fix this one, please help: https://gitlab.com/gitlab-org/gitlab/-/jobs/683182842
Edit: Never mind, it passed ¯\_(ツ)_/¯Edited by Marcin Sedlak-Jakubowski
assigned to @rajatgitlab and @alexives and unassigned @msedlakjakubowski
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 973c6177 and 159d8020
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.01 MB 4.01 MB - 0.0 % mainChunk 3.16 MB 3.16 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Marcin Sedlak-Jakubowski
Looks good to me! I was going to suggest that this should get reviewed for by Technical Writing, but then I realized that's you. I'll go ahead and pass this to a maintainer.
assigned to @oswaldo and unassigned @alexives and @rajatgitlab
- Resolved by Achilleas Pipinellis
non-blocking: So we get two sets of TW eyes on this - @axil would you mind a quick look?
assigned to @axil