Skip to content

Replace mis-used CSS class

David O'Regan requested to merge 227838-h3-h4-class-fix into master

What does this MR do?

A small MVC for #227838 (closed) where we replace the mis-used class="h4" on a h3 element with a equivalent gitlab utility set 😄

<h4 ref="sectionHeader" class="gl-my-3! gl-py-1">

We need to use the gl-my-3! as we need to override the applied in-project CSS and we use the combo of the my and py to achieve the same 10px 😄

Screenshots

Before After
Screenshot_2020-08-12_at_14.36.18 Screenshot_2020-08-12_at_15.10.42

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #227838 (closed)

Edited by David O'Regan

Merge request reports