Disable loading hasNextPage value for Security Dashboards
What does this MR do?
Related to #233017
We have noticed that loading PageInfo.hasNextPage for vulnerabilities in Group Security Dashboard with hundreds of empty projects causes timeouts on database. We need to work on investigating and resolving the problem with SQL query, but for now we have to disable loading hasNextPage
from GraphQL for that type. Instead we are simply checking if endCursor
not equals NULL
, if endCursor
equals NULL
that means that there is no additional pages/results to load. One downside of this change is that we will be doing one extra call to GraphQL API with the last page to simply receive empty list with endCursor
set to NULL.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team