Skip to content

Add bucket to gitlab_sql_duration_seconds

What does this MR do?

!38159 (merged) has limited the number of buckets for gitlab_sql_duration_seconds to the ones we use in our metrics catalog.

- buckets [0.01, 0.05, 0.1, 0.25, 0.5, 1.0, 2.5, 5.0]
+ buckets [0.05, 0.1]

This MR adds back the 0.25 bucket, as it is required for calculating our key database metrics, in particular our Database Primary Performance Indicator: Query apdex with 100ms target, 250ms tolerable.

(sum(rate(gitlab_sql_duration_seconds_bucket{le="0.1"}[5m])) + sum(rate(gitlab_sql_duration_seconds_bucket{le="0.25"}[5m]))) / 2 
 / 
sum(rate(gitlab_sql_duration_seconds_count[5m]))

Part of #227305 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Merge request reports