Skip to content

Fix parallel jobs dropdown from cutting off in the pipeline graph

What does this MR do?

When on the pipeline graph page where we can see every job, there might be instances where the dropdown that list all of the parallel jobs gets cut off at the bottom. This is because the dropdown html element is inside the pipeline graph container, but the container might be to small to render the full dropdown.

To easily fix this, we add a minimum height to the container bigger than the max-height of the dropdown so we know for sure that the dropdown will never get cut off.

Screenshots

Before

Screen_Shot_2020-08-11_at_9.17.26_AM Screen_Shot_2020-08-11_at_9.17.35_AM

After

Screen_Shot_2020-08-11_at_9.16.58_AM Screen_Shot_2020-08-11_at_9.17.08_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #231348 (closed)

Edited by Frédéric Caplette

Merge request reports