Skip to content

Backport spec fixes for upcoming upgrade to Jest 26

Vitaly Slobodin requested to merge vs-backport-fixes-for-jest-twenty-six into master

What does this MR do?

Prepare our specs for the next major update to Jest 26:

Babel does not transpile destructuring in Vue.js templates:

  • ee/spec/frontend/analytics/cycle_analytics/components/recent_activity_card_spec.js
  • ee/spec/frontend/analytics/group_analytics/components/group_activity_card_spec.js
  • ee/spec/frontend/analytics/shared/components/metric_card_spec.js

Wrap beforeEach hook into function

  • ee/spec/frontend/vulnerabilities/vulnerability_state_dropdown_spec.js
  • spec/frontend/vue_shared/components/identicon_spec.js

Fix import paths in two specs

  • spec/frontend/registry/explorer/pages/details_spec.js
  • spec/frontend/registry/explorer/pages/list_spec.js

See corresponding MR here

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Vitaly Slobodin

Merge request reports