Skip to content

Fix flaky spec in spec/features/issues/gfm_autocomplete_spec.rb

What does this MR do?

This MR fixes the flaky spec in spec/features/issues/gfm_autocomplete_spec.rb

  • GFM autocomplete when tribute_autocomplete feature flag is on assignees lists users who are currently not assigned to the issue when using /assign on the second line

When the user does @ to trigger tribute user autocomplete, the assignees of the issue is read from the frontend store and then cached. However, there can be a situation where the assignees in the frontend store is not updated until after the user has typed @ and an empty list of assignees is cached, so subsequent @ invocations will use the incorrect empty assignees cache value.

I don't believe this requires a changelog since there are no UI/user-facing changes.

Issue: #233462 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #233462 (closed)

Edited by Coung Ngo

Merge request reports