Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 36,070
    • Issues 36,070
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,299
    • Merge Requests 1,299
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Merge Requests
  • !38914

Merged
Created Aug 07, 2020 by Dmitry Gruzd@dgruzdDeveloper0 of 13 tasks completed0/13 tasks

Automate the deletion of the old Index after a reindex

  • Overview 78
  • Commits 9
  • Pipelines 24
  • Changes 17

What does this MR do?

This MR implements the automatic deletion of the original elasticsearch index after the reindexing process is completed.

#225436 (closed)

Migration output

$ VERSION=20200807132726 bin/rake db:migrate:up
== 20200807132726 AddDeleteOriginalIndexAtToReindexingTasks: migrating ========
-- add_column(:elastic_reindexing_tasks, :delete_original_index_at, :datetime_with_timezone)
   -> 0.0009s
== 20200807132726 AddDeleteOriginalIndexAtToReindexingTasks: migrated (0.0032s)

Migration Rollback

$ VERSION=20200807132726 bin/rake db:migrate:down
== 20200807132726 AddDeleteOriginalIndexAtToReindexingTasks: reverting ========
-- remove_column(:elastic_reindexing_tasks, :delete_original_index_at)
   -> 0.0018s
== 20200807132726 AddDeleteOriginalIndexAtToReindexingTasks: reverted (0.0047s)

Frontend changes

  • ee/app/views/admin/application_settings/_elasticsearch_form.html.haml

Screenshots

Warning message v.1

Screenshot_2020-08-11_at_12.50.44

Warning message v.2

Screenshot_2020-08-17_at_11.13.34

After the cancel button is pressed

Screenshot_2020-08-13_at_11.39.49

Does this MR meet the acceptance criteria?

Conformity

  • Changelog entry
  • Documentation (if required)
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • Database guides
  • Separation of EE specific content

Availability and Testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • Tested in all supported browsers
  • Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #225436 (closed)

Edited Aug 17, 2020 by Dmitry Gruzd
Assignee
Assign to
Reviewer
Request review from
13.3
Milestone
13.3 (Past due)
Assign milestone
Time tracking
Reference: gitlab-org/gitlab!38914
Source branch: 225436-reindex-delete-original-index