Remove uneeded find_personal_access_token helper [RUN AS-IF-FOSS]
What does this MR do?
Removes the #find_personal_access_token method in the package helper that overrides the one in lib/gitlab/auth/auth_finders.rb.
This override prevents package apis to support the use of the Private-Token header authentication method by default.
By removing this method it makes package APIS support the header authentication in addition to basic http auth.
As @10io explained below, API::APIGuard::HelperMethods#access_token is overriden for the API and already calls find_personal_access_token_from_http_basic_auth. The change introduced in 89199938 made this proposed code being removed redundant.
Ref #235045 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team