Skip to content

Add AmazonEKSClusterPolicy to Kubernetes instructions

Serena Fang requested to merge serenafang-master-patch-98011 into master

What does this MR do?

Replace AmazonEKSServicePolicy with AmazonEKSClusterPolicy to Kubernetes instructions. I was following our docs and ran into ROLLBACK_ERROR, and the AWS CloudFormation stack data suggested adding AmazonEKSClusterPolicy to the policies instead of AmazonEKSServicePolicy like our docs instruct.

From the AWS docs: Prior to April 16, 2020, AmazonEKSServicePolicy was also required and the suggested name was eksServiceRole. With the AWSServiceRoleForAmazonEKS service-linked role, that policy is no longer required.

Tested this by creating an EKS cluster with our GUI with just AmazonEKSServicePolicy (failed, rollback error), both AmazonEKSServicePolicy and AmazonEKSClusterPolicy (worked, but redundant) and just AmazonEKSClusterPolicy (worked). Seems like ServicePolicy is unnecessary.

Screenshots

Bildschirmfoto_2020-08-06_um_9.34.14_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Serena Fang

Merge request reports