Revert "Remove use of LegacyGithubClient in GithubController"
What does this MR do?
This MR reverts a change that caused to no longer show a full list of projects coming from GitHub.
From: https://gitlab.slack.com/archives/CLX7WMSKW/p1596468168017900
Different users are seeing different projects, but I’m aware that permissions and ownership can impact what list is displayed. I looked through the Epic to improve github importing to see if there are known problems but this doesnt seem to match any so far. However some projects are missing. Some are showing imported already, some are showing available, but some are simply missing. There are no errors in the browser console hinting at some sort of pagination issue. He can also see both private/public. Anyone have ideas or thoughts on how to figure our why this repo isnt showing up in the importer list?
I made a change of adding alias_method :octokit, :api in legacy github client as well as !37555 (diffs) which made legacy client to skip method_missing path that included pages concatenation handling.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team