Skip to content

Resolve "Custom renderers cleanup - erb"

Derek Knox requested to merge 232567-templater-inline-erb into master

What does this MR do?

It iterates on the previously introduced templater static site editor pre-processing step to handle two additional use-cases:

  • Content that contains inline ERB
  • HTML blocks
    • If this templater solution proves robust enough, we could potentially remove the render_html_block.js custom renderer. It was currently left in as HTML comment syntax isn't accounted for in this MR.

We'll need at least one more follow-up to handle existing code blocks (we want to leave those as-is)

Screenshots

before after
Screen_Shot_2020-08-06_at_9.06.20_AM Screen_Shot_2020-08-06_at_8.05.24_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Derek Knox

Merge request reports

Loading