Skip to content

Update gldeprecatedbutton to glbutton

Marcel Amirault requested to merge marcel-update-deprecated-button-3 into master

What does this MR do?

Closes #219775 (closed)

During development, we discovered that this was not something possible with borderless icon buttons. Explained at !38763 (comment 403365983). This copies the styling workaround used in !36480 (merged), so we'll have similarity between different uses of the topbar component.

Screenshots

Before

Screen_Shot_2020-08-06_at_14.17.35

After

Screen_Shot_2020-09-04_at_12.40.37

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Marcel Amirault

Merge request reports