Skip to content

Remove external url data from props in favor of store

Miguel Rincon requested to merge 229709-remove-dashboard-props into master

What does this MR do?

Remove external url data from props in favor of using store properties

As we want to allow users to switch between dashboard dynamically, we should remove fixed props that a set from the HTML in favor of a dynamic data that is fetched later in the execution.

Screenshots

A small smoke test, I added a an External URL in the configuration at Settings -> Operations:

image

The external dashboard button is present at http://127.0.0.1:3000/root/autodevops-deploy/-/metrics/:

Screen_Shot_2020-08-04_at_4.12.19_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #229709 (closed)

Edited by Miguel Rincon

Merge request reports