Fix style-lint warnings for `app/assets/stylesheets/framework/toggle.scss`
requested to merge 27767-fix-the-following-style-lint-errors-and-warnings-for-app-assets-stylesheets-framework-toggle into master
What does this MR do?
- Fixes the following stylelint warnings (from #27767 (closed)):
87:5 ⚠ ".toggle-icon" and ".toggle-status-checked (app/assets/stylesheets/framework/toggle.scss -67:5)" have the same properties. stylelint-gitlab/duplicate-selectors
113:7 ⚠ ".toggle-status-checked" and ".toggle-status-unchecked (app/assets/stylesheets/framework/toggle.scss -71:5)" have the same stylelint-gitlab/duplicate-selectors
properties.
117:7 ⚠ ".toggle-status-unchecked" and ".toggle-icon (app/assets/stylesheets/framework/toggle.scss -87:5)" have the same stylelint-gitlab/duplicate-selectors
properties.
- Updates toggle to use Pajamas-conforming blue (
gl-blue-500
) - Fixes icon alignment
- Update icon to use
GlIcon
component
Follow-up to improve specs: !38544 (merged)
Screenshots
"On" state
Before | After |
---|---|
"Off" state
Before | After |
---|---|
Disabled state
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Tom Quirk