Fix for project_security_dashboard_spec
What does this MR do?
From issue #233362 (closed) , it appears that an intermittent failure in this spec is caused by the user not being logged in, and therefore the Security Dashboard link is unavailable.
This MR introduces a Flow::Login.sign_in_unless_signed_in call before visiting the project (and navigating to Security Dashboard).
The previous retry mechanism introduced to try to workaround this issue is removed, as the root cause is that we are not logged in.
Screenshots
See - #233362 (comment 389671963)
User is not logged in, Security and Compliance link to the Project Dashboard is unavailable.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
/closes #233362 (closed)