Skip to content

Re-name "Delete" button to "Archive" on Design Tab

Tom Quirk requested to merge gvso/gitlab-220964-rename-design-delete-button into master

What does this MR do?

Continuing on from @gvso's work in !34586 (closed):

This MR changes the delete button for an archive button. As mentioned at #220964 (closed), currently it's scary to click the "Delete" button for one or more designs, because it sounds serious.

This MR only makes the necessary change in the design_management/ application (design_management_legacy is ignored)

A few additional css changes have been made to maintain better consistency in spacing of elements.

screenshots

Before After
Screen_Shot_2020-08-06_at_1.23.40_pm Screen_Shot_2020-08-06_at_1.13.13_pm
Screen_Shot_2020-08-06_at_1.25.50_pm Screen_Shot_2020-08-06_at_1.10.57_pm

Modal

Screen_Shot_2020-08-06_at_1.55.09_pm

Toolbar loading bug fix

Before After
bug fix

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Tom Quirk

Merge request reports