Skip to content

Show blank empty text for approved by in MR widget

Samantha Ming requested to merge 233082-remove-none-in-approved-by into master

What does this MR do?

This MR removes the "None" text when in an empty state. Now it will just display empty text.

image

Testing Case

  1. Go to a Merge Request
  2. Expand the MR Widget
  • When there is no "Approved by", no text is shown
No approved Yes approved
image image

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #233082 (closed)

Edited by Samantha Ming

Merge request reports