Skip to content

Target stubs for embed domains

Sarah Yasonik requested to merge sy-fix-leaky-domain into master

What does this MR do?

The tests for metrics embeds have (up until now) stubbed Gitlab.config.gitlab.url globally. This has led to some unintended leakage around caching and memoization.

This MR couples the stub more tightly to the usage of Gitlab.config.gitlab.url to prevent further leakage.

This is a non-user-facing change, so I'm leaving a changelog off.

Closes #233077 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Sarah Yasonik

Merge request reports