Skip to content

Revert "Merge branch 218012-vulnerabilities-are-incorrectly-marked..."

Alan (Maciej) Paruszewski requested to merge revert-bd10bff3 into master

What does this MR do?

Related to #233017 and #233114

We have discovered that recently merged change is causing database timeouts which results in 500 error for end users (https://sentry.gitlab.net/gitlab/gitlabcom/issues/1727335). As for now this does not happen to many customers and we are certain that this is not always reproducible (especially on smaller projects):

Example 1 (small project, working without any issues): https://gitlab.com/gitlab-org/secure/security-reports/-/security/vulnerabilities/346147 Example 2 (large project, responding with 500): https://gitlab.com/gitlab-org/gitlab/-/security/vulnerabilities/2775540

To make sure we are not returning unfriendly 500 errors we need to revisit that issue and find solution that will not cause timeouts in database.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Alan (Maciej) Paruszewski

Merge request reports