Skip to content

Perform redis UNLINK instead of DEL in ElasticsearchEnabledCache

Igor requested to merge es-cache-unlink into master

What does this MR do?

We are seeing some slow DELs in the redis-cache cluster for gitlab.com. See https://gitlab.com/gitlab-com/gl-infra/infrastructure/-/issues/11018.

We have some DELs against a potentially quite large hash in redis. We can switch from DEL to an explicit UNLINK call similar to what was done for SetCache: !27116 (merged).

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Igor

Merge request reports