Skip to content

Fix vulnerability statistics calculation

Mehmet Emin INAC requested to merge fix_statistic_calculation_logic into master

What does this MR do?

SystemNoteService.change_vulnerability_state has a side effect on the vulnerability object which is changing the previous_changes and breaking the statistics calculation logic.

Therefore we have to execute the statistics logic before the SystemNoteService.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Merge request reports