Improve project snippet internal access spec
What does this MR do?
In this MR we improve the spec spec/features/security/project/snippet/internal_access_spec.rb. In local, the time went from 1 min and 18 seconds to 55 seconds. Therefore, the improvement is 23 seconds.
Refs #228692 (closed)
Screenshots
Before
Top 10 slowest examples (43.55 seconds, 55.5% of total time):
Internal Project Snippets Access GET /:project_path/snippets is expected to be allowed for admin
32.99 seconds ./spec/features/security/project/snippet/internal_access_spec.rb:16
Internal Project Snippets Access GET /:project_path/snippets/:id for a private snippet is expected to be allowed for owner
1.77 seconds ./spec/features/security/project/snippet/internal_access_spec.rb:60
Internal Project Snippets Access GET /:project_path/snippets/:id for an internal snippet is expected to be allowed for admin
1.44 seconds ./spec/features/security/project/snippet/internal_access_spec.rb:45
Internal Project Snippets Access GET /:project_path/snippets is expected to be allowed for maintainer
1.24 seconds ./spec/features/security/project/snippet/internal_access_spec.rb:18
Internal Project Snippets Access GET /:project_path/snippets is expected to be allowed for reporter
1.12 seconds ./spec/features/security/project/snippet/internal_access_spec.rb:20
Internal Project Snippets Access GET /:project_path/snippets/:id for a private snippet is expected to be allowed for developer
1.05 seconds ./spec/features/security/project/snippet/internal_access_spec.rb:62
Internal Project Snippets Access GET /:project_path/snippets is expected to be allowed for developer
1.01 seconds ./spec/features/security/project/snippet/internal_access_spec.rb:19
Internal Project Snippets Access GET /:project_path/snippets/:id for an internal snippet is expected to be allowed for guest
0.98658 seconds ./spec/features/security/project/snippet/internal_access_spec.rb:50
Internal Project Snippets Access GET /:project_path/snippets/:id for an internal snippet is expected to be allowed for maintainer
0.9749 seconds ./spec/features/security/project/snippet/internal_access_spec.rb:47
Internal Project Snippets Access GET /:project_path/snippets/:id for a private snippet is expected to be allowed for guest
0.97344 seconds ./spec/features/security/project/snippet/internal_access_spec.rb:64
Finished in 1 minute 18.41 seconds (files took 8.89 seconds to load)After
Top 10 slowest examples (30.97 seconds, 55.9% of total time):
Internal Project Snippets Access GET /:project_path/snippets is expected to be allowed for admin
24.45 seconds ./spec/features/security/project/snippet/internal_access_spec.rb:15
Internal Project Snippets Access GET /:project_path/snippets/:id for an internal snippet is expected to be allowed for admin
0.89715 seconds ./spec/features/security/project/snippet/internal_access_spec.rb:44
Internal Project Snippets Access GET /:project_path/snippets is expected to be allowed for maintainer
0.82185 seconds ./spec/features/security/project/snippet/internal_access_spec.rb:17
Internal Project Snippets Access GET /:project_path/snippets is expected to be allowed for reporter
0.74739 seconds ./spec/features/security/project/snippet/internal_access_spec.rb:19
Internal Project Snippets Access GET /:project_path/snippets is expected to be allowed for guest
0.71565 seconds ./spec/features/security/project/snippet/internal_access_spec.rb:20
Internal Project Snippets Access GET /:project_path/snippets/:id for a private snippet is expected to be allowed for maintainer
0.68912 seconds ./spec/features/security/project/snippet/internal_access_spec.rb:60
Internal Project Snippets Access GET /:project_path/snippets is expected to be allowed for developer
0.67606 seconds ./spec/features/security/project/snippet/internal_access_spec.rb:18
Internal Project Snippets Access GET /:project_path/snippets is expected to be allowed for user
0.67124 seconds ./spec/features/security/project/snippet/internal_access_spec.rb:21
Internal Project Snippets Access GET /:project_path/snippets is expected to be denied for visitor
0.65312 seconds ./spec/features/security/project/snippet/internal_access_spec.rb:23
Internal Project Snippets Access GET /:project_path/snippets is expected to be allowed for owner
0.64912 seconds ./spec/features/security/project/snippet/internal_access_spec.rb:16
Finished in 55.4 seconds (files took 6.37 seconds to load)