Resolve "Add issue state counts to GraphQL"
What does this MR do?
A small MVC for the frontend of #235988 (closed)
Screenshots
| Table | Searched | Mobile |
|---|---|---|
 |
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #235988 (closed)
Merge request reports
Activity
changed milestone to %13.3
added Deliverable GraphQL backend devopsmonitor grouprespond workflowin dev labels
assigned to @oregand
added 2 commits
Everything works well! The only issue appears to be that the incident count are not filtered by incident label or project and rather returning the count of total issues in the DB?Fixed by passing the
$labelNamesto the query
Edited by David O'Reganmentioned in issue #232580 (closed)
added documentation label
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Paul Gascou-Vaillancourt ( @pgascouvaillancourt) (UTC-4, 5 hours behind@oregand)Andrew Fontaine ( @afontaine) (UTC-4, 5 hours behind@oregand)If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Edited by 🤖 GitLab Bot 🤖- Resolved by Nicolò Maria Mezzopera
@lauraMon
Could I get a frontend review for this please?
- Last reply by David O'Regan
added workflowin review label and removed workflowin dev label
mentioned in issue #229400 (closed)
mentioned in epic &3814 (closed)
mentioned in epic &3814 (closed)
@lauraMon most of those review items are from my MR (!38263 (merged)).
@oregand should rebase this MR off my branch to get up to date.
- Resolved by Nicolò Maria Mezzopera
@lauraMon
Thank you for the great review! I have updated the naming conventions to Status on the frontend instead of state(I opted for state originally as thats what is returned in the GraphQL payload). I have also rebased off @seanarnold branch to pull in the new backend changes
WDYT?
Should we consolidate a single naming convention for state vs status? I feel like this is something that might come back to haunt us later if we dont have a good reason for maintaining both
Edited by David O'Regan - Last reply by Nicolò Maria Mezzopera
added 844 commits
-
4d5515e8...d1ad82d2 - 843 commits from branch
232580-issue-state-counts-graphql - 31a76c32 - Update from feedback
-
4d5515e8...d1ad82d2 - 843 commits from branch
added 5 commits
-
31a76c32...0387f2cd - 2 commits from branch
232580-issue-state-counts-graphql - aaac05da - Add changelog entry
- 66680bb7 - Update graphql schema
- d79a66b2 - Add status count badge
Toggle commit list-
31a76c32...0387f2cd - 2 commits from branch
assigned to @ohoral
marked the checklist item Changelog entry as completed
marked the checklist item Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. as completed
marked the checklist item Tested in all supported browsers as completed
assigned to @nmezzopera and unassigned @ohoral
unassigned @nmezzopera
assigned to @ntepluhina
assigned to @nmezzopera
unassigned @ntepluhina
unassigned @nmezzopera
added 1067 commits
-
68dcfa30...60f47371 - 1065 commits from branch
232580-issue-state-counts-graphql - 71263935 - Add status count badge
- 96e589d9 - Apply 1 suggestion(s) to 1 file(s)
-
68dcfa30...60f47371 - 1065 commits from branch
added 654 commits
-
671c6431...e4695080 - 651 commits from branch
master - db2c4c52 - Add status count badge
- 220e7ece - Apply 1 suggestion(s) to 1 file(s)
- fe0038fa - Updated per feedback
Toggle commit list-
671c6431...e4695080 - 651 commits from branch
enabled an automatic merge when the pipeline for d1f42f78 succeeds
-
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits e4695080 and e98d1219
Entrypoint / Name Size before Size after Diff Diff in percent average 4.01 MB 4.01 MB - 0.0 % mainChunk 3.16 MB 3.16 MB - 0.0 % 
Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.incidents.index 278.99 KB 289.69 KB +10.71 KB 3.8 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@justin_ho,@leipertor@mikegreiling) for review, if you are unsure about the size increase.Please look at the full report for more details
Read more about how this report works.
Generated by
mentioned in commit 74c0580b
added workflowstaging label and removed workflowin review label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in issue #238569 (closed)
This merge request has been deployed to the release.gitlab.net environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.
added published label
added typemaintenance label
