Skip to content

Implement DAST Modal for Pipeline View

Dheeraj Joshi requested to merge djadmin-pipeline-dast-modal into master

Implementation for #224687 (closed)

What does this MR do?

This MR

  1. adds a link to view the scanned resources scanned by DAST (or any other secure job),
  2. uses an existing modal component to display the scanned resources

Edge cases covered

  • If there are no scanned resources, there shouldn't be any link
  • If there is no download link available, shouldn't show it (handled by the Modal Component)

Feature Flag

This MR also enables the feature flag to show pipeline's security report summary - pipelines_security_report_summary.

Note - This is enabled by default as it could help us disable the feature if something goes wrong (we had a recent prod issue where having a feature flag helped).

Post Merge

  • Test the changes on gitlab.com
  • Create an MR to enable / remove the feature flag

Screenshots

Without Scanned Resources With Scanned Resources DAST Modal (without download link)
image image image

Does this MR meet the acceptance criteria?

Conformity

Edited by Dheeraj Joshi

Merge request reports