Skip to content

Add missing fa-share icon

Thomas Randolph requested to merge defect/missing-fa-share-icon into master

What does this MR do?

The recent switch to fontawesome_custom didn't include every icon.

In this case, symlinks in the HAML blob viewer use fa-share, which isn't loaded.

In production: https://gitlab.com/redbaron1/diffbug/-/blob/master/deployconfig.js

This MR adds fa-share to the custom FontAwesome stylesheet.

Screenshots

Before After
missing readded

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Thomas Randolph

Merge request reports