Skip to content

Enforce namespace storage limit via app setting

Tyler Amos requested to merge 231177-enforce-storage-limit-app-setting into master

What does this MR do?

Instead of gating namespace storage limit checks using GL.com checks (e.g. ::Gitlab.dev_env_or_com?), it will be gated based on a new ApplicationSetting introduced in this MR.

  • Adds a new column, enforce_namespace_storage_limit, to the application_settings table.
  • Allows this setting to be managed via application settings API.

Migration Output

Up:

== 20200728175710 AddEnforceNamespaceStorageLimitToApplicationSettings: migrating
-- add_column(:application_settings, :enforce_namespace_storage_limit, :boolean, {:default=>false, :null=>false})
   -> 0.0038s
== 20200728175710 AddEnforceNamespaceStorageLimitToApplicationSettings: migrated (0.0038s)

Down:

== 20200728175710 AddEnforceNamespaceStorageLimitToApplicationSettings: reverting
-- remove_column(:application_settings, :enforce_namespace_storage_limit, :boolean, {:default=>false, :null=>false})
   -> 0.0076s
== 20200728175710 AddEnforceNamespaceStorageLimitToApplicationSettings: reverted (0.0110s)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Relates to #231177

Edited by Tyler Amos

Merge request reports