Geo - Generic Node Status Bars
What does this MR do?
Closes #228722 (closed)
This change removes the need for a hard coded list of replicable types in the Geo Frontend in regards to Node Status Bars.
In the past we had to manage a list of hard coded node status types and it was a tedious effort to add new ones to the frontend. Please see #225529 (closed) for everything that was required to add just one new one.
Instead, now the backend manages a partly hard-coded (legacy-types) and partly machine generated (Geo SSF) list of replicable types. Then the UI only needs to loop through these and consume the data from our API. This removes the need for any hard-coding in the UI for these sync statuses.
This change also brought back a few old fields to the API response for the sake of generalization, as well as fixed a small bug in the hard-coded data in the backend.
Screenshots
**Note: There should be very little difference between these screenshots by design
Primary Node Card | Secondary Node Card | |
---|---|---|
before | ![]() |
![]() |
after | ![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Closes #228722 (closed)