Skip to content

Feat(Insights Charts): use skeleton chart loader

What does this MR do?

This MR uses the general chart skeleton loader added here: !35012 (merged) for the Insights charts to finalize this ticket #219742 (closed).

Screenshots

Before After
Screen_Recording_2020-07-24_at_15.42.01 Screen_Recording_2020-07-24_at_11.26.12

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

This changes the loader for the charts in the Analytics Insights page. The risk could be it not working correctly, however, the changes made are covered with tests specifically around the loading behavior.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #219742 (closed) Related to #223088 (moved)

Edited by Michael Lunøe

Merge request reports