Feat(Insights Charts): use skeleton chart loader
What does this MR do?
This MR uses the general chart skeleton loader added here: !35012 (merged) for the Insights charts to finalize this ticket #219742 (closed).
Screenshots
Before | After |
---|---|
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
This changes the loader for the charts in the Analytics Insights page. The risk could be it not working correctly, however, the changes made are covered with tests specifically around the loading behavior.
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Closes #219742 (closed) Related to #223088 (moved)
Edited by Michael Lunøe