Rename container registry top-level key in usage ping payload
requested to merge 199193-track-total-number-of-instances-using-an-external-container-registry into master
What does this MR do?
In !37203 (merged) (scheduled for %13.3) we added a new Usage Ping observation for the Container Registry, using a top-level key of container_registry. However, after deploying the corresponding change for version.gitlab.com, we found that a container_registry key existed before %11.1, which led to an error (see https://gitlab.com/gitlab-services/version-gitlab-com/-/issues/374).
This MR renames the Container Registry top-level key from container_registry to container_registry_server, as discussed in #199193 (comment 384136006).
Related to #199193 (closed).
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by João Pereira