Skip to content

WIP: Mr origin 26740

Sean Carroll requested to merge mr-origin-26740 into master

What does this MR do?

Local copy of community contribution !26740 (merged)

This is a suggested approach for unblocking the linked community contribution. The original issue was that searching by releases on the group page did not work. Upon investigation it was determined that there was no controller.

This code extends the original contribution to support:

  • abstraction of logic into a Finder
  • paging
  • testing for N+1 conditions
  • support for finding releases under nested groups

Currently releases cannot be directly attached to groups, so this MR takes the approach that for a group we will search for any releases attached to projects under those groups (& subgroups).

Separately, there is an effort underway to attach releases directly to groups.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Sean Carroll

Merge request reports