Delete deprecated group security dashboard code
What does this MR do?
We have updated the security dashboard code to use GraphQL instead of Vuex in the project to move to Standalone Vulnerabilities, which was released in %13.0 . In doing so, we started from scratch and created new files, slowly deprecated the old security dashboard code. Now that the project has been out for a couple of milestones and the feature flag has been deleted, we can start deleting the old files. That is what I am doing in this MR; deleting the old group security dashboard files, which have been replaced by
- ee/app/assets/javascripts/pages/groups/security/dashboard/show/index.js
- ee/app/assets/javascripts/security_dashboard/first_class_init.js
- ee/app/assets/javascripts/security_dashboard/components/first_class_group_security_dashboard.vue
Delete deprecated group security dashboard code
- delete the final reference to deprecated code
- remove unused code
- delete tests
Screenshots
| File | Proof deleted file is not referenced anymore |
|---|---|
group_init |
 |
group_security_dashboard.vue |
 |
| Proof the default to security dashboard still works | redirect_720p |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #223189 (closed)