Skip to content

Refactor Strategy Component to Break Out Parameter

Andrew Fontaine requested to merge refactor-feature-flags-strategies-fe into master

What does this MR do?

By splitting out strategy into one sub-component per strategy, we should be able to make it easier to add more strategies down the road.

Strategy sub-components are responsible for knowing how they alter the strategy object, and emit it upward when changes are made.

The parent strategy component keeps a map between strategy types and their components, utilizing Vue's component component to dynamically display the correct sub-component in the DOM.

Screenshots

No visual changes

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

closes #259679 (closed)

Edited by Andrew Fontaine

Merge request reports