Refactor Strategy Component to Break Out Parameter
What does this MR do?
By splitting out strategy into one sub-component per strategy, we should be able to make it easier to add more strategies down the road.
Strategy sub-components are responsible for knowing how they alter the strategy object, and emit it upward when changes are made.
The parent strategy component keeps a map between strategy types and
their components, utilizing Vue's component
component to dynamically
display the correct sub-component in the DOM.
Screenshots
No visual changes
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
closes #259679 (closed)
Edited by Andrew Fontaine