Skip to content

Replace VulnerabilityHistoryResolver to use HistoricalStatistic model

What does this MR do?

Related to #217811 (closed)

This MR removes unused method from Vulnerability model and adds new logic that is used to prepare statistics from HistoricalStatistic model instead of calculating it manually from Vulnerability model.

Queries

SELECT "date" AS "day",
  unnest(
    array [SUM("info"), SUM("unknown"), SUM("low"), SUM("medium"), SUM("high"), SUM("critical")]
  ) AS "count",
  unnest(
    array ['info', 'unknown', 'low', 'medium', 'high', 'critical']
  ) AS "severity"
FROM "vulnerability_historical_statistics"
WHERE "vulnerability_historical_statistics"."date" >= '2020-07-20'
  AND "vulnerability_historical_statistics"."date" < '2020-07-27'
  AND "vulnerability_historical_statistics"."project_id" IN (
    SELECT "projects"."id"
    FROM "projects"
    WHERE "projects"."namespace_id" = 9970
  )
GROUP BY "vulnerability_historical_statistics"."date"
ORDER BY "vulnerability_historical_statistics"."date" ASC,
  "severity" ASC;

https://explain.depesz.com/s/eXmZ (~1.683 ms)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Alan (Maciej) Paruszewski

Merge request reports