Add a new router page to "Add a Panel"
What does this MR do?
Part of #228759 (closed)
This feature is behind a feature flag:metrics_dashboard_new_panel_page See: &2882
This change adds a new empty page at:
-
/metrics/panel/newand /metrics/my_dashboard.yml/panel/new
In addition to the previous routes:
/metrics//metrics/my_dashboard.yml
The new page includes a "go back" button and heading as in the design, the back button works as a sanity check the router is working correctly.
Additionally it extends the backend routes so they match our frontend ones, and the page is displayed for all of them.
Notes
- Some tweaks were needed so the backend routes matches our frontend routes, this might be fragile so we can discuss ways to fix this.
- As the new page cannot be reached from the UI, I propose to not require a feature flag to disable this page. No changelog would be included in this MR.
- New specs not included yet.
Screenshots
Recording of navigation to the page and back to the dashboard:
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Miguel Rincon