Replace scanned_resources_for_csv with ScannedResource object
requested to merge reports_scanned_resources_should_return_a_scanned_resource_object_227703 into master
What does this MR do?
Having a Security:Report return scanned_resources as an array of hashes, then converting that to an array of OpenStruct to render as a CSV file is a little convoluted. The MR aims to remedy that by having the Security::Report return the scanned_resources as an array of ScannedResources, therefore no conversion for CSV is required.
This MR related to #227703 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Craig Smith