Skip to content

Allow optional keyset pagination for branch list API

What does this MR do?

We have added support for native gitaly pagination in #208738 (closed). However, we can't enable it because it would break existing use cases and so we're following existing keyset pagination conversion although this doesn't match it 100%.

Please see !35819 (comment 381037263) and https://docs.gitlab.com/ee/api/README.html#keyset-based-pagination for more information.

This at least gives us the ability to turn the feature on without breaking current behaviour and the gitaly pagination can be used by passing in pagination: 'keyset' option. Also, it doesn't match above keyset based pagination convention 100% as it is backed by gitaly and not ActiveRecord.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #208738 (closed)

Edited by Sincheol (David) Kim

Merge request reports