Skip to content

Draft: Enable cop Lint/AmbiguousRegexpLiteral

Peter Leitzen requested to merge pl-rubocop-lint-ambiguous-regexp-literal into master

What does this MR do?

This MR enables 👮 Lint/AmbiguousRegexpLiteral which helps to reduce Ruby compile time warning such as:

warning: ambiguous first argument; put parentheses or a space even after `/' operator

See #196852 (comment 382619398)

Refs also the ancient gitlab-foss#17478 (closed)

Offenses to fix

17540 files inspected, 162 offenses detected

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports