Skip to content

Update closed MRs on push

Patrick Bajao requested to merge 225579-reset-approvals-closed-mrs into master

What does this MR do?

In !29420 (merged), we started filtering the branches that we update on push. It only looks at branches with open MRs.

It caused a regression wherein closed MRs approvals weren't being reset even when reset_approvals_on_push setting is set to true.

This updates the MergeRequests::PushedBranchesService to include closed MRs with matching source branches as well.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

#225579 (closed)

Edited by Patrick Bajao

Merge request reports