Skip to content

Don't disable LFS when repo access is disabled in project settings

Tom Quirk requested to merge retain-lfs-setting-always into master

What does this MR do?

Issue: #229575 (closed)

LFS should be allowed to be enabled even when repository access is not. From #229575 (closed):

LFS is disabled, which also breaks the Design Management feature because it uses LFS exclusively for storage.

This MR removes the force-disabling of LFS when repo access is disabled. This means LFS can be enabled, even when Repository is disabled.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Tom Quirk

Merge request reports