Skip to content

Fix package_file storage computation

What does this MR do?

Fix package_file storage computation

When package_files are created without an explicit size, the size is updated on an after_save hook by copying over the size from the file object.

This is called after the statistics hook therefore the delta is not added to the statistics.

This fixes that issue and updates the statistic spec to be more robust.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #225424 (closed) Closes #36426 (closed)

Edited by Giorgenes Gelatti

Merge request reports