Skip to content

Fix CSV downloads for multiple series in the same chart (readded after revert)

Miguel Rincon requested to merge revert-2aafa3bb into master

What does this MR do?

NOTE: The original MR was reverted, this MR re added the changes of !36556 (merged).

This MR fixes cases in which the "Dashboard Panel" failed rendering when data was undefined/missing from the results, such as when data is loading or fails to load.

Additionally is exports a complete dataset of values for each metric in the panel, so it covers cases in which our data has more complex shapes, like when multiple metrics/series are used.

Screenshots

No changes in UI, but given this panel with multiple series:

We get different CSV results:

Before After (all data columns)
image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #214627 (closed)

Edited by Miguel Rincon

Merge request reports