Skip to content

Follow-up: Updated components to use new GitLab UI classes

What does this MR do?

This MR updates some of the non-GitLab UI CSS classes in the compliance dashboard to use new GitLab UI equivalents.

These classes were merged in gitlab-ui!1570 (merged), gitlab-ui!1571 (merged) and gitlab-ui!1572 (merged) and comes from discussions in !32440 (comment 373563125).

Screenshots

Screen_Recording_2020-08-05_at_16.43.38

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

The URL for the dashboard is https://[GDK_HOST]/groups/gitlab-org/-/security/compliance_dashboard

If you don't see any merge requests, you can run the following in your rails console in your gitlab directory to add a merge request event:

# Include FactoryBot
FactoryBot.definition_file_paths = [Rails.root.join('ee', 'spec', 'factories')]
FactoryBot.find_definitions

group = Group.find(22) # The group id for gitlab-org, replace it for a different group 
user = User.find(1) # The admin id on GDK, replace it for a different user

project = FactoryBot.create(:project, :repository, :public, group: group)
merge_request = FactoryBot.create(:merge_request, source_project: project, state: :merged)
FactoryBot.create(:event, :merged, project: project, target: merge_request, author: user, created_at: 10.minutes.ago)

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Robert Hunt

Merge request reports