Skip to content

Implement a parser to extract SAST configuration

Saikat Sarkar requested to merge parse_gitlab_ci into master

What does this MR do?

This MR is related to this issue. The purpose of this MR is to create a parser that can extract default and current values of different entities from SAST template and .gitlab-ci.yml file. The extracted values are used to populate the JSON for SAST UI configuration. Following is a list of changes that are made in this MR.

- Delete unused graphQL resolver(`app/graphql/resolvers/ci_configuration/sast_resolver.rb`).

- Move `sast_ci_configuration` to EE. As most of the SAST config UI work is in EE. Initially, we decided to keep this field in CE as we are moving SAST to CORE. But, for now, this should be part of EE.

- Implement a parser for SAST template and .gitlab-ci.yml file.
- This MR contains 500+ lines of code change. But, most of them are related to moving code to EE and configuration JSON file.

Screenshots

.gitlab-ci.yml

Screen_Shot_2020-07-17_at_12.11.59_PM

GraphQL query result

Screen_Shot_2020-07-22_at_11.09.59_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Saikat Sarkar

Merge request reports