Set default job timeout to 90m and dast to 4h
What does this MR do?
Sets a default timeout to 90m after the increase of the Project level timeout to 4h in https://gitlab.com/gitlab-com/gl-infra/infrastructure/-/issues/10520#note_379588904
Sets the dast job timeout (which isn't currently running) to 4h.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
added Engineering Productivity maintenancepipelines + 1 deleted label
@rymai - WDYT of this? I added this to lower the default timeout back to 90m and specify one for dast per https://gitlab.com/gitlab-com/gl-infra/infrastructure/-/issues/10520#note_380024239
assigned to @rymai
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer Engineering Productivity for CI, Danger Rémy Coutable ( @rymai
) (UTC+2)Rémy Coutable ( @rymai
) (UTC+2)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/167318712 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/167339233 downstream.The
gitlab-qa
downstream pipeline passed. .
- Resolved by Rémy Coutable
@kwiebers Good idea! @ngeorge1 I think you'll need to pick this line in !25453 (closed).
changed milestone to %13.2
enabled an automatic merge when the pipeline for 2fec3400 succeeds
mentioned in commit f0aa0034
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label