WIP: Prometheus Client refactor idea draft
What does this MR do?
This is demonstartional MR for the refactor idea:
My rough idea is to add
PrometheusApiConfiguration
model, and associate it withProject
PrometheusService
andClusters::Applications::Prometheus
, we could also add some sort of metadata to define priority of multiple available configurations to be used, when querying data. This new model could also be passed toPrometheus::ProxyService
in order to initializePrometheusClient
.
classDiagram
PromethuesAPIConfig --o PrometheusService
PromethuesAPIConfig -- ApplicationsPrometheus
class PromethuesAPIConfig {
# add
+ api_url
+ headers
priority
}
class PrometheusService{
# remove
- api_url
- headers
}
class ApplicationsPrometheus{
# remove
- api_url
- headers
}
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Mikołaj Wawrzyniak