Skip to content

Add setting for max doc size Elasticsearch

What does this MR do?

Introduce a new admin setting for the maximum indexed document size. Pass this through from Rails to our indexer to ensure we keep consistent value with the same setting needed for index.highlight.max_analyzed_offset when creating the index.

The corresponding change to the gitlab-elasticsearch-indexer is gitlab-elasticsearch-indexer!84 (merged) .

Screenshots

Screen_Shot_2020-07-22_at_4.33.21_pm

Database Migrations

Up

$ bin/rake db:migrate:up VERSION=20200720053909
== 20200720053909 AddElasticsearchIndexedFileSizeLimitKbToApplicationSettings: migrating
-- add_column(:application_settings, :elasticsearch_indexed_file_size_limit_kb, :integer, {:null=>false, :default=>1024})
   -> 0.0062s
== 20200720053909 AddElasticsearchIndexedFileSizeLimitKbToApplicationSettings: migrated (0.0063s)

Down

$ bin/rake db:migrate:down VERSION=20200720053909
== 20200720053909 AddElasticsearchIndexedFileSizeLimitKbToApplicationSettings: reverting
-- remove_column(:application_settings, :elasticsearch_indexed_file_size_limit_kb, :integer, {:null=>false, :default=>1024})
   -> 0.0348s
== 20200720053909 AddElasticsearchIndexedFileSizeLimitKbToApplicationSettings: reverted (0.0377s)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

#219329 (closed) #8638 (closed)

Edited by Dylan Griffith

Merge request reports